cbts-alec-johnson opened a new issue, #8857:
URL: https://github.com/apache/hudi/issues/8857

   **Describe the problem you faced**
   
   Column comments are not synced to the AWS Glue Data Catalog when setting 
`hoodie.datasource.hive_sync.sync_comment` to `true` and adding column comments 
in the dataframe schema metadata.
   
   **To Reproduce**
   
   Steps to reproduce the behavior:
   
   1. Add a comment to a field in a dataframe. 
   2. Set `hoodie.datasource.hive_sync.sync_comment` to `true`
   3. Write the dataframe to the AWS Glue Catalog
   4.
   
   ```python
   df = df.withMetadata('col1', {'comment': 'description of the column'})
   ```
   
   **Expected behavior**
   
   Setting `hoodie.datasource.hive_sync.sync_comment` to `true` when the 
dataframe has column comments should sync the comments to the Glue Catalog.
   
   **Environment Description**
   
   * Hudi version : 0.12.1
   
   * Spark version : 3.3.0
   
   * Hive version :
   
   * Hadoop version :
   
   * Storage (HDFS/S3/GCS..) : S3
   
   * Running on Docker? (yes/no) : no
   
   
   **Additional context**
   
   It looks like the comment is manually set to empty in this function here. It 
should instead get the comment from the dataframe schema metadata.
   
   
https://github.com/apache/hudi/blob/c6dadd4cb5d82d4afa9dbfd4b089c02ebe06c14c/hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java#L446-L457
   
   **Stacktrace**
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to