danny0405 commented on code in PR #8865:
URL: https://github.com/apache/hudi/pull/8865#discussion_r1213858024
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -63,6 +63,7 @@ public static org.apache.hadoop.conf.Configuration
getHiveConf(Configuration con
if (explicitDir != null) {
hadoopConf.addResource(new Path(explicitDir, "hive-site.xml"));
}
+ conf.toMap().forEach(hadoopConf::set);
return hadoopConf;
Review Comment:
Seems you wanna pass around the hive config options through Flink sql
options, this is not suggested, We prefer to config the hive properties through
the `hive-site.xml` in the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
