danny0405 commented on code in PR #8832:
URL: https://github.com/apache/hudi/pull/8832#discussion_r1215228617
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/ConflictResolutionStrategy.java:
##########
@@ -40,7 +40,7 @@ public interface ConflictResolutionStrategy {
* Stream of instants to check conflicts against.
* @return
*/
- Stream<HoodieInstant> getCandidateInstants(HoodieActiveTimeline
activeTimeline, HoodieInstant currentInstant, Option<HoodieInstant>
lastSuccessfulInstant);
+ Stream<HoodieInstant> getCandidateInstants(HoodieTableMetaClient metaClient,
HoodieInstant currentInstant, Option<HoodieInstant> lastSuccessfulInstant);
Review Comment:
It is hard code to false now, kind of think it is hard to maintain for the
invoker to know whether to refresh these timelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
