parisni commented on code in PR #8740:
URL: https://github.com/apache/hudi/pull/8740#discussion_r1217980277
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -238,6 +235,66 @@ public void updateTableProperties(String tableName,
Map<String, String> tablePro
}
}
+ private void setComments(List<Column> columns, Map<String, Option<String>>
commentsMap) {
+ columns.forEach(column -> {
+ String comment = commentsMap.getOrDefault(column.getName(),
Option.empty()).orElse(null);
+ column.setComment(comment);
+ });
+ }
+
+ private String getTableDoc() {
+ try {
+ return new
TableSchemaResolver(metaClient).getTableAvroSchema(true).getDoc();
+ } catch (Exception e) {
Review Comment:
AFAIK the avro schema is already reused by running method
`getTableAvroSchema` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
