danny0405 commented on code in PR #8684:
URL: https://github.com/apache/hudi/pull/8684#discussion_r1222533305
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1453,7 +1453,11 @@ public static String
deleteMetadataTablePartition(HoodieTableMetaClient dataMeta
* @return The fileID
*/
public static String getFileIDForFileGroup(MetadataPartitionType
partitionType, int index) {
- return String.format("%s%04d", partitionType.getFileIdPrefix(), index);
+ if (partitionType == MetadataPartitionType.FILES) {
+ return String.format("%s%04d-%d", partitionType.getFileIdPrefix(),
index, 0);
+ } else {
Review Comment:
Discuss offline, this is a fix for consistency of base file fileGroup id and
the log files, because the bulk_insert create handle would append a suffix
(starts from `-0`) for each file it creates.
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1453,7 +1453,11 @@ public static String
deleteMetadataTablePartition(HoodieTableMetaClient dataMeta
* @return The fileID
*/
public static String getFileIDForFileGroup(MetadataPartitionType
partitionType, int index) {
- return String.format("%s%04d", partitionType.getFileIdPrefix(), index);
+ if (partitionType == MetadataPartitionType.FILES) {
+ return String.format("%s%04d-%d", partitionType.getFileIdPrefix(),
index, 0);
+ } else {
Review Comment:
Discussed offline, this is a fix for consistency of base file fileGroup id
and the log files, because the bulk_insert create handle would append a suffix
(starts from `-0`) for each file it creates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
