yihua commented on code in PR #8921:
URL: https://github.com/apache/hudi/pull/8921#discussion_r1224645928
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieInternalRowUtils.scala:
##########
@@ -202,7 +202,7 @@ object HoodieInternalRowUtils {
renamedColumnsMap: JMap[String, String],
fieldNameStack: JDeque[String]):
RowFieldUpdater = {
(newDataType, prevDataType) match {
- case (newType, prevType) if prevType == newType =>
+ case (newType, prevType) if prevType.sql == newType.sql =>
Review Comment:
Could you add a few tests in this change, e.g., making nested types nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
