danny0405 commented on code in PR #8437:
URL: https://github.com/apache/hudi/pull/8437#discussion_r1225147630
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1553,14 +1553,14 @@ void testBuiltinFunctionWithCatalog(String operation) {
}
@ParameterizedTest
- @EnumSource(value = HoodieTableType.class)
- void testWriteAndReadWithDataSkipping(HoodieTableType tableType) {
+ @MethodSource("tableTypeAndDataSkippingParams")
+ void testWriteAndReadWithDataSkipping(HoodieTableType tableType, boolean
dataSkipping) {
TableEnvironment tableEnv = batchTableEnv;
String hoodieTableDDL = sql("t1")
Review Comment:
Can we write a new test instead of modifying existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
