nsivabalan commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1225581002
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -390,6 +403,18 @@ public HoodieMetadataPayload
preCombine(HoodieMetadataPayload previousRecord) {
return new HoodieMetadataPayload(key, combineBloomFilterMetadata);
case METADATA_TYPE_COLUMN_STATS:
return new HoodieMetadataPayload(key,
combineColumnStatsMetadata(previousRecord));
+ case METADATA_TYPE_RECORD_INDEX:
+ // TODO: does not work with updates
Review Comment:
we might need to account for deleted records here. in a follow up patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
