Zouxxyy commented on code in PR #5297:
URL: https://github.com/apache/hudi/pull/5297#discussion_r1225687139
##########
README.md:
##########
@@ -72,32 +74,31 @@ mvn clean javadoc:aggregate -Pjavadocs
### Build with different Spark versions
-The default Spark version supported is 2.4.4. To build for different Spark
versions and Scala 2.12, use the
-corresponding profile
+The default Spark version supported is 2.4.4. Refer to the table below for
building with different Spark and Scala versions.
-| Label | Artifact Name for Spark Bundle | Maven Profile Option | Notes |
-|--|--|--|--|
-| Spark 2.4, Scala 2.11 | hudi-spark2.4-bundle_2.11 | `-Pspark2.4` | For
Spark 2.4.4, which is the same as the default |
-| Spark 2.4, Scala 2.12 | hudi-spark2.4-bundle_2.12 | `-Pspark2.4,scala-2.12`
| For Spark 2.4.4, which is the same as the default and Scala 2.12 |
-| Spark 3.1, Scala 2.12 | hudi-spark3.1-bundle_2.12 | `-Pspark3.1` | For Spark
3.1.x |
-| Spark 3.2, Scala 2.12 | hudi-spark3.2-bundle_2.12 | `-Pspark3.2` | For Spark
3.2.x |
-| Spark 3, Scala 2.12 | hudi-spark3-bundle_2.12 | `-Pspark3` | This is the
same as `Spark 3.2, Scala 2.12` |
-| Spark, Scala 2.11 | hudi-spark-bundle_2.11 | Default | The default profile,
supporting Spark 2.4.4 |
-| Spark, Scala 2.12 | hudi-spark-bundle_2.12 | `-Pscala-2.12` | The default
profile (for Spark 2.4.4) with Scala 2.12 |
+| Maven build options | Expected Spark bundle jar name |
Notes |
+|:--------------------------|:---------------------------------------------|:-------------------------------------------------|
+| (empty) | hudi-spark-bundle_2.11 (legacy bundle name) |
For Spark 2.4.4 and Scala 2.11 (default options) |
+| `-Dspark2.4` | hudi-spark2.4-bundle_2.11 |
For Spark 2.4.4 and Scala 2.11 (same as default) |
Review Comment:
May I ask why we choose to use -D to specify the profile
I know there is such an activation by property in one profile
```xml
<activation>
<property>
<name>spark2.4</name>
</property>
</activation>
```
Why not just use -PprofileName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
