amrishlal commented on code in PR #8879:
URL: https://github.com/apache/hudi/pull/8879#discussion_r1227046893
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/bootstrap/SparkFullBootstrapDataProviderBase.java:
##########
@@ -84,7 +84,7 @@ public JavaRDD<HoodieRecord> generateInputRecords(String
tableName, String sourc
Boolean.parseBoolean(KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.defaultValue())));
try {
return DataSourceUtils.createHoodieRecord(gr, orderingVal,
keyGenerator.getKey(gr),
- props.getString("hoodie.datasource.write.payload.class"));
+ props.getString("hoodie.datasource.write.payload.class"),
null);
Review Comment:
We added an extra argument so that `DataSourceUtils.createHoodieRecord` can
take `scala.Option<HoodieRecordLocation> recordLocation` as an input argument.
Here there is no recordLocation specified so passing in `Option.apply(null)` to
maintain original behavior. I could add another signature for
`DataSourceUtils.createHoodieRecord` to avoid adding null here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
