xicm commented on code in PR #8911:
URL: https://github.com/apache/hudi/pull/8911#discussion_r1227456677


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/Hive2Shim.java:
##########
@@ -53,4 +59,17 @@ public int getDays(Object dateWritable) {
   public long getMills(Object timestamp) {
     return ((Timestamp) timestamp).getTime();
   }
+
+  @Override
+  public PartitionDesc getPartitionDesc(Map<Path, PartitionDesc> 
pathToPartitionInfo, Path dir,
+      Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cacheMap) throws 
IOException {
+
+    try {
+      Class<?> hiveUtilsClass = 
Class.forName("org.apache.hudi.hadoop.utils.HudiHiveFileFormatUtils");

Review Comment:
   Do we need reflection here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to