thomasg19930417 commented on code in PR #8911: URL: https://github.com/apache/hudi/pull/8911#discussion_r1227598591
########## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/HiveCompatibleShimBelow23.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.hadoop.utils.shims; + +import java.io.IOException; +import java.lang.reflect.Method; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.mapred.JobConf; + +/** + * When the hive version is less than hive version 2.3 + */ +public class HiveCompatibleShimBelow23 implements HiveCompatibleShim { + + private static HiveCompatibleShimBelow23 INSTANCE = new HiveCompatibleShimBelow23(); + + public static HiveCompatibleShim getInstance() { + return INSTANCE; + } + + @Override + public void invokePushProjectAndFilters(JobConf job, Class<?> inputFormatClass, Path splitPath) + throws IOException { + try { + Class hiveInputFormatClass = this.getClass().getSuperclass(); Review Comment: @xicm Sorry, I have re-modified here. In addition, it seems that it is not possible to directly inherit HiveInputFormat when the above is greater than hive2.3. There are some other contexts in the pushProjectionsAndFilters method. I think there may be some problems when calling directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
