danny0405 commented on code in PR #8876:
URL: https://github.com/apache/hudi/pull/8876#discussion_r1228022553
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamSource.scala:
##########
@@ -151,9 +160,9 @@ class HoodieStreamSource(
// Consume the data between (startCommitTime, endCommitTime]
val incParams = parameters ++ Map(
DataSourceReadOptions.QUERY_TYPE.key ->
DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL,
- DataSourceReadOptions.READ_BY_STATE_TRANSITION_TIME.key() ->
useStateTransitionTime.toString,
DataSourceReadOptions.BEGIN_INSTANTTIME.key ->
startCommitTime(startOffset),
- DataSourceReadOptions.END_INSTANTTIME.key -> endOffset.commitTime
+ DataSourceReadOptions.END_INSTANTTIME.key -> endOffset.commitTime,
Review Comment:
Do we have plan to bookkeep the completion time so that we can find out the
missing instants automatically?
Maybe just create a JIRA first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
