danny0405 commented on code in PR #8929:
URL: https://github.com/apache/hudi/pull/8929#discussion_r1228876173
##########
hudi-aws/src/main/java/org/apache/hudi/config/GlueCatalogSyncClientConfig.java:
##########
@@ -39,4 +39,11 @@ public class GlueCatalogSyncClientConfig extends
HoodieConfig {
.markAdvanced()
.sinceVersion("0.14.0")
.withDocumentation("Glue catalog sync based client will skip archiving
the table version if this config is set to true");
+
+ public static final ConfigProperty<Boolean> GLUE_ENABLE_METADATA_TABLE =
ConfigProperty
+ .key(GLUE_CLIENT_PROPERTY_PREFIX + "enable_metadata_table")
Review Comment:
general looks good, only one question: where does these option naming
convention come from?
##########
hudi-aws/src/main/java/org/apache/hudi/config/GlueCatalogSyncClientConfig.java:
##########
@@ -39,4 +39,11 @@ public class GlueCatalogSyncClientConfig extends
HoodieConfig {
.markAdvanced()
.sinceVersion("0.14.0")
.withDocumentation("Glue catalog sync based client will skip archiving
the table version if this config is set to true");
+
+ public static final ConfigProperty<Boolean> GLUE_ENABLE_METADATA_TABLE =
ConfigProperty
+ .key(GLUE_CLIENT_PROPERTY_PREFIX + "enable_metadata_table")
Review Comment:
generally looks good, only one question: where does these option naming
convention come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
