Zouxxyy commented on code in PR #8955:
URL: https://github.com/apache/hudi/pull/8955#discussion_r1229598004


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetReader.java:
##########
@@ -50,24 +51,20 @@ public class HoodieAvroParquetReader extends 
RecordReader<Void, ArrayWritable> {
   private Schema baseSchema;

Review Comment:
   > In my [origin PR HUDI-83](https://github.com/apache/hudi/pull/3391/files) 
I didn't declare the `baseSchema` variable and didn't modify the 
`getCurrentValue` method. In fact I would like to know if there is any problem 
or no NPE if we don't declare the `baseSchema`?
   
   I have tested that `baseSchema ` need to be used in getCurrentValue, 
otherwise, the result field will be null, like this 
https://github.com/apache/hudi/pull/7173#issuecomment-1316208189
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to