prashantwason commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1230243882
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -275,30 +243,51 @@ public Map<Pair<String, String>,
HoodieMetadataColumnStats> getColumnStats(final
List<String> columnStatKeys = new ArrayList<>(sortedKeys);
HoodieTimer timer = HoodieTimer.start();
- List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>>
hoodieRecordList =
+ Map<String, HoodieRecord<HoodieMetadataPayload>> hoodieRecords =
Review Comment:
There are other code paths (e.g.
BaseTableMetadata::fetchAllFilesInPartitionPaths) where the keys are not sorted
before calling getRecordByKeys(). It will be hard to require all code paths to
sort before calling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
