yihua commented on code in PR #8944:
URL: https://github.com/apache/hudi/pull/8944#discussion_r1230292770
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -209,8 +209,7 @@ private int doCluster(JavaSparkContext jsc) throws
Exception {
// Instant time is not specified
// Find the earliest scheduled clustering instant for execution
Option<HoodieInstant> firstClusteringInstant =
- metaClient.getActiveTimeline().firstInstant(
- HoodieTimeline.REPLACE_COMMIT_ACTION,
HoodieInstant.State.REQUESTED);
+
metaClient.getActiveTimeline().filterPendingReplaceTimeline().firstInstant();
Review Comment:
This is intentional because we should not execute a clustering instant which
is already inflight. If a replacecommit is inflight and the job failed, the
right process is to roll back the inflight clustering to requested state first,
see:
https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDTableServiceClient.java#L198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
