yihua opened a new pull request, #8991:
URL: https://github.com/apache/hudi/pull/8991

   ### Change Logs
   
   #7561 introduced a bug where in a case, the partition changes may be missed 
in the meta sync, e.g., the following active timeline:
   
   ```
   ts3.rollback, ts50.commit, ts51.commit, ts52.commit, ...
   ```
   
   and ts49.commit and ts48.commit are archived.
   
   If ts47 is the last sync commit time, and ts48.commit or ts49.commit has 
partition changes, meta sync misses such changes.
   
   This above issue is solved by a separate PR #8388 where the hive sync client 
returns the right timeline which gives write commits only for checking.
   
   This PR makes sure the problematic API implementation 
(`TimelineUtils.getCommitsTimelineAfter`) is still fixed.
   
   Existing tests are enhanced:
   - `TestTimelineUtils.testGetCommitsTimelineAfter `: this test fails before 
this PR and passes after the PR.
   - `TestHiveSyncTool. testBasicSync`: this test passes before and after this 
PR on master.  Note that, without #8388, this test would fail without this PR.
   
   Fixes a bug.
   
   ### Risk level
   
   low
   
   ### Documentation Update
   
   We need to update release notes on the regression.
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to