danny0405 commented on code in PR #8987:
URL: https://github.com/apache/hudi/pull/8987#discussion_r1231690955
##########
hudi-common/src/main/java/org/apache/hudi/common/model/WriteOperationType.java:
##########
@@ -68,6 +68,10 @@ public enum WriteOperationType {
* Convert string value to WriteOperationType.
*/
public static WriteOperationType fromValue(String value) {
+ if (value == null) {
+ // NOTE: Write operation type of commit metadata generated by Flink may
be null for the version before 0.12.
Review Comment:
We should fix it to be never null. Personally I don't like code like this,
it is a bug fix, not for version compatibility purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
