codope commented on code in PR #8982:
URL: https://github.com/apache/hudi/pull/8982#discussion_r1231809984
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/ChainedTransformer.java:
##########
@@ -112,6 +118,30 @@ private void validateIdentifier(String id, Set<String>
identifiers, String confi
}
}
+ private StructType getExpectedTransformedSchema(TransformerInfo
transformerInfo, JavaSparkContext jsc, SparkSession sparkSession,
+ Option<StructType>
incomingStructOpt, Option<Dataset<Row>> rowDatasetOpt, TypedProperties
properties) {
+ if (!sourceSchemaOpt.isPresent() && !rowDatasetOpt.isPresent()) {
Review Comment:
Should it be an `||` instead of `&&`? Don't we want both schema and row
dataset to be present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
