codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1231909053
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -170,6 +171,17 @@ public static HoodieWriteConfig createMetadataWriteConfig(
throw new HoodieMetadataException("Unsupported Metrics Reporter type
" + writeConfig.getMetricsReporterType());
}
}
- return builder.build();
+
+ HoodieWriteConfig metadataWriteConfig = builder.build();
+ // Inline compaction and auto clean is required as we do not expose this
table outside
+ ValidationUtils.checkArgument(!metadataWriteConfig.isAutoClean(),
"Cleaning is controlled internally for Metadata table.");
Review Comment:
Good to have validations for invariants, just in case behavior changes in
future can be taught in ut/ft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
