danny0405 commented on code in PR #8933:
URL: https://github.com/apache/hudi/pull/8933#discussion_r1232024093
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -321,21 +318,6 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable catalogTable, boo
options.put(TableOptionProperties.PK_CONSTRAINT_NAME,
resolvedSchema.getPrimaryKey().get().getName());
options.put(TableOptionProperties.PK_COLUMNS, pkColumns);
- // check preCombine
- final String preCombineField =
conf.getString(FlinkOptions.PRECOMBINE_FIELD);
- if (!resolvedSchema.getColumnNames().contains(preCombineField)) {
- if (OptionsResolver.isDefaultHoodieRecordPayloadClazz(conf)) {
- throw new HoodieValidationException("Option '" +
FlinkOptions.PRECOMBINE_FIELD.key()
- + "' is required for payload class: " +
DefaultHoodieRecordPayload.class.getName());
Review Comment:
The preCombine field can be omitted only when it is append mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
