danny0405 commented on code in PR #9003:
URL: https://github.com/apache/hudi/pull/9003#discussion_r1233169087
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -296,7 +296,7 @@ protected class AppendLogWriteCallback implements
HoodieLogFileWriteCallback {
public boolean preLogFileOpen(HoodieLogFile logFileToAppend) {
// we use create rather than createIfNotExists because create method can
trigger marker-based early conflict detection.
WriteMarkers writeMarkers =
WriteMarkersFactory.get(config.getMarkersType(), hoodieTable, instantTime);
- return writeMarkers.create(partitionPath, logFileToAppend.getFileName(),
IOType.APPEND,
+ return writeMarkers.createIfNotExists(partitionPath,
logFileToAppend.getFileName(), IOType.APPEND,
Review Comment:
also needs to fix the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
