danny0405 commented on code in PR #8993:
URL: https://github.com/apache/hudi/pull/8993#discussion_r1233455583
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSourceStorage.scala:
##########
@@ -284,6 +289,120 @@ class TestCOWDataSourceStorage extends
SparkClientFunctionalTestHarness {
.filter(action =>
action.equals(HoodieTimeline.REPLACE_COMMIT_ACTION)).size > 0)
}
+ @ParameterizedTest
+ @CsvSource(value = Array(
+ "org.apache.hudi.client.validator.SqlQueryEqualityPreCommitValidator|"
+ + "select count(*) from <TABLE_NAME> where driver is
null|true|false|false",
+ "org.apache.hudi.client.validator.SqlQueryEqualityPreCommitValidator|"
+ + "select count(*) from <TABLE_NAME> where driver is
null|true|true|false",
+ "org.apache.hudi.client.validator.SqlQueryEqualityPreCommitValidator|"
+ + "select count(*) from <TABLE_NAME> where rider is null|true|true|true",
+ "org.apache.hudi.client.validator.SqlQueryEqualityPreCommitValidator|"
Review Comment:
Can we avoid to hardcode these validators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
