danny0405 commented on code in PR #9008:
URL: https://github.com/apache/hudi/pull/9008#discussion_r1233464848
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -653,13 +659,14 @@ public static class DeltaSyncService extends
HoodieIngestionService {
private final Option<ConfigurationHotUpdateStrategy>
configurationHotUpdateStrategyOpt;
- public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs,
Configuration conf,
+ public DeltaSyncService(Config cfg, HoodieSparkEngineContext
sparkEngineContext, FileSystem fs, Configuration conf,
Option<TypedProperties> properties) throws
IOException {
super(HoodieIngestionConfig.newBuilder()
.isContinuous(cfg.continuousMode)
.withMinSyncInternalSeconds(cfg.minSyncIntervalSeconds).build());
this.cfg = cfg;
- this.jssc = jssc;
+ this.sparkEngineContext = sparkEngineContext;
+ this.jssc = sparkEngineContext.getJavaSparkContext();
this.fs = fs;
Review Comment:
Do we need to keep 2 engine contexts as members ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
