xushiyan commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1233589359
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -73,35 +71,25 @@ public abstract class BaseTableMetadata implements
HoodieTableMetadata {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTableMetadata.class);
- protected static final long MAX_MEMORY_SIZE_IN_BYTES = 1024 * 1024 * 1024;
- // NOTE: Buffer-size is deliberately set pretty low, since MT internally is
relying
- // on HFile (serving as persisted binary key-value mapping) to do
caching
- protected static final int BUFFER_SIZE = 10 * 1024; // 10Kb
-
protected final transient HoodieEngineContext engineContext;
protected final SerializablePath dataBasePath;
protected final HoodieTableMetaClient dataMetaClient;
protected final Option<HoodieMetadataMetrics> metrics;
protected final HoodieMetadataConfig metadataConfig;
- // Directory used for Spillable Map when merging records
- protected final String spillableMapDirectory;
- protected boolean isMetadataTableEnabled;
- protected boolean isBloomFilterIndexEnabled = false;
- protected boolean isColumnStatsIndexEnabled = false;
+ protected boolean isMetadataTableInitialized;
- protected BaseTableMetadata(HoodieEngineContext engineContext,
HoodieMetadataConfig metadataConfig,
- String dataBasePath, String
spillableMapDirectory) {
+ protected BaseTableMetadata(HoodieEngineContext engineContext,
HoodieMetadataConfig metadataConfig, String dataBasePath) {
this.engineContext = engineContext;
this.dataBasePath = new SerializablePath(new CachingPath(dataBasePath));
this.dataMetaClient = HoodieTableMetaClient.builder()
.setConf(engineContext.getHadoopConf().get())
.setBasePath(dataBasePath)
.build();
- this.spillableMapDirectory = spillableMapDirectory;
this.metadataConfig = metadataConfig;
- this.isMetadataTableEnabled = metadataConfig.enabled();
+ this.isMetadataTableInitialized =
dataMetaClient.getTableConfig().isMetadataTableEnabled();
Review Comment:
renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
