guanlisheng commented on PR #9013: URL: https://github.com/apache/hudi/pull/9013#issuecomment-1598399037
hey @danny0405, I understood your ask generally while it is not that easy. currently, both PRs are to change the input parameters of `averageBytesPerRecord`. https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java#L164-L174 I think locating the change within `averageBytesPerRecord` would be a good implementation, and also UT-friendly. furtherly, leveraging `hoodie.parquet.max.file.size` along with `fileSizeThreshold` would achieve the same goal. https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java#L386-L388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
