vinothchandar commented on code in PR #8909:
URL: https://github.com/apache/hudi/pull/8909#discussion_r1237284139
##########
website/docs/quick-start-guide.md:
##########
@@ -494,12 +492,23 @@ select 1 as id, 'a1' as name, 1000 as ts, '2021-12-09' as
dt, '10' as hh;
insert into hudi_cow_pt_tbl partition(dt = '2021-12-09', hh='11') select 2,
'a2', 1000;
```
-**NOTICE**
-- By default, if `preCombineKey ` is provided, `insert into` use `upsert`
as the type of write operation, otherwise use `insert`.
-- We support to use `bulk_insert` as the type of write operation, just need to
set two configs: `hoodie.sql.bulk.insert.enable` and `hoodie.sql.insert.mode`.
Example as follow:
+**Write Modes**
+By default, `insert into` uses `bulk_insert` write mode.
+To use other write modes, use the following table. Required Configs must be
explicitly set to use the specified insert mode.
+Optional Configs are not required, but must **not** be set to a **different**
value than listed in the column.
+
+
+| Write Mode | Required Configs
| Optional Configs
|
+|---------------|----------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------|
+| `upsert` | `hoodie.sql.insert.mode=upsert`
| `hoodie.sql.bulk.insert.enable=false`<br/>
`hoodie.datasource.write.insert.drop.duplicates=false`
|
Review Comment:
I find this config a bit confusing to read `hoodie.sql.insert.mode=upsert`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
