danny0405 commented on code in PR #9036:
URL: https://github.com/apache/hudi/pull/9036#discussion_r1238276302
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -419,16 +419,7 @@ public HoodieMetadataPayload
preCombine(HoodieMetadataPayload previousRecord) {
case METADATA_TYPE_COLUMN_STATS:
return new HoodieMetadataPayload(key,
combineColumnStatsMetadata(previousRecord));
case METADATA_TYPE_RECORD_INDEX:
- // TODO: does not work with updates
- if (previousRecord.recordIndexMetadata.getInstantTime() !=
recordIndexMetadata.getInstantTime()) {
- throw new HoodieMetadataException(String.format("InstantTime for %s
should not change from %s to %s", previousRecord.key,
- previousRecord, this));
- }
- // TODO: This does not work with clustering
- if
(!previousRecord.getRecordGlobalLocation().equals(getRecordGlobalLocation())) {
- throw new HoodieMetadataException(String.format("Location for %s
should not change from %s to %s", previousRecord.key,
- previousRecord, this));
- }
+ // No need to merge with previous record index, always pick the latest
payload.
return this;
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
