yihua commented on code in PR #8840: URL: https://github.com/apache/hudi/pull/8840#discussion_r1240098101
########## hudi-common/src/test/java/org/apache/hudi/common/util/TestJsonUtils.java: ########## @@ -1,60 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -package org.apache.hudi.common.util; - -import org.junit.jupiter.api.Test; - -import java.time.Instant; -import java.util.Arrays; -import java.util.List; -import java.util.stream.Collectors; - -import static org.junit.jupiter.api.Assertions.assertEquals; - -public class TestJsonUtils { Review Comment: This PR only fixes the jsr310 dependency without changing the serialization. So the tests would fail. You can put up a separate PR on fixing the serialization of data types, but is that required? That is going to change the col stats persisted in the MDT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
