guanlisheng commented on code in PR #9013:
URL: https://github.com/apache/hudi/pull/9013#discussion_r1241003008


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java:
##########
@@ -379,6 +374,9 @@ protected static long averageBytesPerRecord(HoodieTimeline 
commitTimeline, Hoodi
         Iterator<HoodieInstant> instants = 
commitTimeline.getReverseOrderedInstants().iterator();
         while (instants.hasNext()) {
           HoodieInstant instant = instants.next();
+          if (instant.getAction().equals(REPLACE_COMMIT_ACTION)) {
+            continue;

Review Comment:
   hi @danny0405, I just reverted the code to the very first one.  
   Whether including the log or not, the current one would be better than the 
released one, at least for MoR tables
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to