danny0405 commented on code in PR #9038:
URL: https://github.com/apache/hudi/pull/9038#discussion_r1241963611
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -267,6 +267,13 @@ public HoodieTimeline getCommitsTimeline() {
return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION,
DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION));
}
+ /**
+ * Get all instants (commits, delta commits, replace, compaction) that
produce new data or merge file, in the active timeline.
+ */
+ public HoodieTimeline getCommitsAndMergesTimeline() {
+ return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION,
DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION, COMPACTION_ACTION));
+ }
Review Comment:
getCommitsAndMergesTimeline -> getCommitsAndCompactionTimeline
Can we also add a test case for this incremental cleaning scenario, where
partition path got switched and the old partition files could not be cleaned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
