danny0405 commented on code in PR #9049:
URL: https://github.com/apache/hudi/pull/9049#discussion_r1243054136
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -167,6 +167,7 @@ private void updateHeartbeat(Path heartbeatFilePath) throws
HoodieHeartbeatExcep
this.fs.create(heartbeatFilePath, true);
outputStream.close();
} catch (IOException io) {
+ LOG.error("Unable to generate heartbeat,heartbeatFilePath:{}",
heartbeatFilePath, io);
throw new HoodieHeartbeatException("Unable to generate heartbeat ", io);
}
Review Comment:
We can remove the log: `LOG.error("Unable to generate
heartbeat,heartbeatFilePath:{}", heartbeatFilePath, io);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
