codope commented on code in PR #9069:
URL: https://github.com/apache/hudi/pull/9069#discussion_r1244734889
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -131,7 +133,8 @@ public HoodieTimelineArchiver(HoodieWriteConfig config,
HoodieTable<T, I, K, O>
metaClient.getActiveTimeline().getCommitsTimeline(),
cleanerPolicy,
cleanerCommitsRetained,
- latestCommit.isPresent()
+ latestCommit.isPresent() &&
(latestCommit.get().getTimestamp().length() == MILLIS_INSTANT_ID_LENGTH
+ || latestCommit.get().getTimestamp().length() ==
SECS_INSTANT_ID_LENGTH)
Review Comment:
Instead of checking here, should we fix
`HoodieActiveTinline#parseDateFromInstantTime`? There could be other callers
too and it's essentially a timestamp parsing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
