xushiyan commented on code in PR #9077:
URL: https://github.com/apache/hudi/pull/9077#discussion_r1245141414
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieIndex.java:
##########
@@ -111,23 +104,17 @@ private static Stream<Arguments> indexTypeParams() {
{IndexType.GLOBAL_BLOOM, true, false},
{IndexType.SIMPLE, true, true},
{IndexType.SIMPLE, true, false},
- {IndexType.SIMPLE, false, true},
- {IndexType.SIMPLE, false, false},
{IndexType.GLOBAL_SIMPLE, true, true},
{IndexType.GLOBAL_SIMPLE, true, false},
- {IndexType.GLOBAL_SIMPLE, false, true},
- {IndexType.GLOBAL_SIMPLE, false, false},
- {IndexType.BUCKET, false, true},
+ {IndexType.BUCKET, true, false},
{IndexType.BUCKET, false, false},
- {IndexType.RECORD_INDEX, true, true},
- {IndexType.RECORD_INDEX, true, false}
+ {IndexType.RECORD_INDEX, true, true}
Review Comment:
- popluateMetaFields (true/false) only applies to bucket index.
- only test record index when MDT enabled
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -1069,89 +1066,6 @@ public void testDeletesForInsertsInSameBatch(boolean
populateMetaFields) throws
populateMetaFields);
}
- /**
- * Test update of a record to different partition with Global Index.
- */
- @ParameterizedTest
- @EnumSource(value = IndexType.class, names = {"GLOBAL_BLOOM",
"GLOBAL_SIMPLE"})
- public void testUpsertsUpdatePartitionPathGlobalBloom(IndexType indexType)
throws Exception {
- testUpsertsUpdatePartitionPath(indexType, getConfig(),
SparkRDDWriteClient::upsert);
- }
-
- /**
- * This test ensures in a global bloom when update partition path is set to
true in config, if an incoming record has mismatched partition
- * compared to what is in storage, then appropriate actions are taken. i.e.
old record is deleted in old partition and new one is inserted
- * in the new partition.
- * test structure:
- * 1. insert 1 batch
- * 2. insert 2nd batch with larger no of records so that a new file group is
created for partitions
- * 3. issue upserts to records from batch 1 with different partition path.
This should ensure records from batch 1 are deleted and new
- * records are upserted to the new partition
- *
- * @param indexType index type to be tested for
- * @param config instance of {@link HoodieWriteConfig} to use
- * @param writeFn write function to be used for testing
- */
- private void testUpsertsUpdatePartitionPath(IndexType indexType,
HoodieWriteConfig config,
Review Comment:
Covered in `TestGlobalIndexEnableUpdatePartitions`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieIndex.java:
##########
@@ -377,61 +390,6 @@ public void testTagLocationAndDuplicateUpdate(IndexType
indexType, boolean popul
recordLocations.foreach(entry ->
assertEquals(recordKeyToPartitionPathMap.get(entry._1.getRecordKey()),
entry._1.getPartitionPath(), "PartitionPath mismatch"));
}
- @ParameterizedTest
- @MethodSource("indexTypeParams")
- public void testSimpleTagLocationAndUpdateWithRollback(IndexType indexType,
boolean populateMetaFields, boolean enableMetadataIndex) throws Exception {
Review Comment:
merged into `testSimpleTagLocationAndUpdate`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieIndex.java:
##########
@@ -680,75 +555,6 @@ public void testCheckIfValidCommit() throws Exception {
assertFalse(HoodieIndexUtils.checkIfValidCommit(timeline,
instantTimestampSec));
}
- @ParameterizedTest
- @ValueSource(booleans = {true})
- public void testRecordIndexTagLocationAndUpdate(boolean populateMetaFields)
throws Exception {
Review Comment:
covered in parameterized `testSimpleTagLocationAndUpdate`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestHoodieGlobalBloomIndex.java:
##########
@@ -346,104 +343,9 @@ public void testTagLocation() throws Exception {
}
}
- @Test
- public void testTagLocationWhenShouldUpdatePartitionPath() throws Exception {
Review Comment:
Covered in `TestGlobalIndexEnableUpdatePartitions`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieIndex.java:
##########
@@ -543,89 +501,6 @@ public void
testTagLocationAndFetchRecordLocations(IndexType indexType, boolean
}
}
- @ParameterizedTest
- @EnumSource(value = IndexType.class, names = {"GLOBAL_BLOOM",
"GLOBAL_SIMPLE"})
- public void
testSimpleGlobalIndexTagLocationWhenShouldUpdatePartitionPath(IndexType
indexType) throws Exception {
Review Comment:
Covered in `TestGlobalIndexEnableUpdatePartitions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
