danielfordfc commented on code in PR #9059:
URL: https://github.com/apache/hudi/pull/9059#discussion_r1245903270
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -639,7 +639,13 @@ private Pair<SchemaProvider, Pair<String,
JavaRDD<HoodieRecord>>> fetchFromSourc
BuiltinKeyGenerator builtinKeyGenerator = (BuiltinKeyGenerator)
HoodieSparkKeyGeneratorFactory.createKeyGenerator(props);
List<HoodieRecord> avroRecords = new ArrayList<>();
while (genericRecordIterator.hasNext()) {
- GenericRecord genRec = genericRecordIterator.next();
+ GenericRecord genRec = null;
+ try {
+ genRec = genericRecordIterator.next();
+ } catch (IllegalArgumentException e) {
+ LOG.warn("Handling exception for transaction topic - " +
e.getMessage());
+ break;
Review Comment:
@aditiwari01 I see, I guess for most deltastreamer usages we would need it
to handle both use cases, where it handles it during deltastreamer record
production, and the above case we tested, as running the tool in both batch and
continuous is very common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]