danny0405 commented on code in PR #9058:
URL: https://github.com/apache/hudi/pull/9058#discussion_r1246016087
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -283,6 +285,8 @@ public HoodieMetadataPayload(Option<GenericRecord>
recordOpt) {
Integer.parseInt(recordIndexRecord.get(RECORD_INDEX_FIELD_FILE_INDEX).toString()),
Long.parseLong(recordIndexRecord.get(RECORD_INDEX_FIELD_INSTANT_TIME).toString()));
}
+ } else {
+ this.isDeletedRecord = true;
Review Comment:
@prashantwason I think @xushiyan and @nsivabalan are addressing that many
metadata POJOs already take a `isDeleted` flag except the recordIndexMetadata,
during the convertion from write status to RLI metadata payload in
`HoodieMetadataPayload#createRecordIndexUpdate`, there is a choice is to mark
the recordIndexMetadata itself as deleted, which keeps the behavior in line
with the other payloads.
But still, in `HoodieMetadataPayload#preCombine`, the merging of RLI infos
should be fixed with the `isDeleted` falg just like others.
If we move to this direction, the changes in `HoodieBackedTableMetadata`
should be unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
