nsivabalan commented on code in PR #8774:
URL: https://github.com/apache/hudi/pull/8774#discussion_r1248439284
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackStrategy.java:
##########
@@ -117,21 +126,22 @@ public List<HoodieRollbackRequest>
getRollbackRequests(HoodieInstant instantToRo
// If there is no delta commit present after the current commit
(if compaction), no action, else we
// need to make sure that a compaction commit rollback also
deletes any log files written as part of the
// succeeding deltacommit.
- boolean higherDeltaCommits =
+ boolean hasHigherCompletedDeltaCommits =
!activeTimeline.getDeltaCommitTimeline().filterCompletedInstants().findInstantsAfter(commit,
1)
.empty();
- if (higherDeltaCommits) {
- // Rollback of a compaction action with no higher deltacommit
means that the compaction is scheduled
+ if (hasHigherCompletedDeltaCommits &&
!isCommitMetadataCompleted) {
Review Comment:
due to async compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
