jonvex commented on code in PR #9083:
URL: https://github.com/apache/hudi/pull/9083#discussion_r1251058371
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala:
##########
@@ -46,16 +47,31 @@ import scala.collection.JavaConversions.mapAsJavaMap
object HoodieCreateRecordUtils {
private val log = LoggerFactory.getLogger(getClass)
- def createHoodieRecordRdd(df: DataFrame,
- config: HoodieWriteConfig,
- parameters: Map[String, String],
- recordName: String,
- recordNameSpace: String,
- writerSchema: Schema,
- dataFileSchema: Schema,
- operation: WriteOperationType,
- instantTime: String,
- isPrepped: Boolean) = {
+ case class createHoodieRecordRddArgs(df: DataFrame,
+ config: HoodieWriteConfig,
+ parameters: Map[String, String],
+ recordName: String,
+ recordNameSpace: String,
+ writerSchema: Schema,
+ dataFileSchema: Schema,
+ operation: WriteOperationType,
+ instantTime: String,
+ isPrepped: Boolean,
Review Comment:
They are used a bit differently. In
`getHoodieKeyAndMaybeLocationFromAvroRecord` there are some differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
