yihua commented on code in PR #9066: URL: https://github.com/apache/hudi/pull/9066#discussion_r1253254054
########## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieMergeOnReadSnapshotReader.java: ########## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.hadoop.realtime; + +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieAvroIndexedRecord; +import org.apache.hudi.common.model.HoodieLogFile; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.table.log.HoodieMergedLogRecordScanner; +import org.apache.hudi.common.util.DefaultSizeEstimator; +import org.apache.hudi.common.util.HoodieRecordSizeEstimator; +import org.apache.hudi.common.util.HoodieTimer; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.ClosableIterator; +import org.apache.hudi.common.util.collection.ExternalSpillableMap; +import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils; +import org.apache.hudi.io.storage.HoodieFileReader; + +import org.apache.avro.Schema; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.mapred.JobConf; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +import static org.apache.hudi.common.config.HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED; +import static org.apache.hudi.common.config.HoodieCommonConfig.SPILLABLE_DISK_MAP_TYPE; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.COMPACTION_LAZY_BLOCK_READ_ENABLED_PROP; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.DEFAULT_COMPACTION_LAZY_BLOCK_READ_ENABLED; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.DEFAULT_MAX_DFS_STREAM_BUFFER_SIZE; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.DEFAULT_SPILLABLE_MAP_BASE_PATH; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.MAX_DFS_STREAM_BUFFER_SIZE_PROP; +import static org.apache.hudi.hadoop.config.HoodieRealtimeConfig.SPILLABLE_MAP_BASE_PATH_PROP; +import static org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils.getBaseFileReader; +import static org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils.getMaxCompactionMemoryInBytes; +import static org.apache.hudi.internal.schema.InternalSchema.getEmptyInternalSchema; + +public class HoodieMergeOnReadSnapshotReader extends AbstractRealtimeRecordReader implements Iterator<HoodieRecord>, AutoCloseable { + + private static final Logger LOG = LoggerFactory.getLogger(HoodieMergeOnReadSnapshotReader.class); + + private final String tableBasePath; + private final List<HoodieLogFile> logFilePaths; + private final String latestInstantTime; + private final Schema readerSchema; + private final JobConf jobConf; + private final HoodieMergedLogRecordScanner logRecordScanner; + private final HoodieFileReader baseFileReader; + private final Map<String, HoodieRecord> logRecordsByKey; + private final Iterator<HoodieRecord> recordsIterator; + private final ExternalSpillableMap<String, HoodieRecord> mergedRecordsByKey; + + public HoodieMergeOnReadSnapshotReader(String tableBasePath, String baseFilePath, + List<HoodieLogFile> logFilePaths, + String latestInstantTime, + Schema readerSchema, + JobConf jobConf, long start, long length, String[] hosts) throws IOException { + super(getRealtimeSplit(tableBasePath, baseFilePath, logFilePaths, latestInstantTime, start, length, hosts), jobConf); + this.tableBasePath = tableBasePath; + this.logFilePaths = logFilePaths; + this.latestInstantTime = latestInstantTime; + this.readerSchema = readerSchema; + this.jobConf = jobConf; + HoodieTimer timer = new HoodieTimer().startTimer(); + this.logRecordScanner = getMergedLogRecordScanner(); + LOG.debug("Time taken to scan log records: {}", timer.endTimer()); + this.baseFileReader = getBaseFileReader(new Path(baseFilePath), jobConf); + this.logRecordsByKey = logRecordScanner.getRecords(); + Set<String> logRecordKeys = new HashSet<>(this.logRecordsByKey.keySet()); + this.mergedRecordsByKey = new ExternalSpillableMap<>( + getMaxCompactionMemoryInBytes(jobConf), + jobConf.get(SPILLABLE_MAP_BASE_PATH_PROP, DEFAULT_SPILLABLE_MAP_BASE_PATH), + new DefaultSizeEstimator(), + new HoodieRecordSizeEstimator(readerSchema), + jobConf.getEnum(SPILLABLE_DISK_MAP_TYPE.key(), SPILLABLE_DISK_MAP_TYPE.defaultValue()), + jobConf.getBoolean(DISK_MAP_BITCASK_COMPRESSION_ENABLED.key(), DISK_MAP_BITCASK_COMPRESSION_ENABLED.defaultValue())); + try (ClosableIterator<String> baseFileIterator = baseFileReader.getRecordKeyIterator()) { + timer.startTimer(); + while (baseFileIterator.hasNext()) { + String key = baseFileIterator.next(); + if (logRecordKeys.contains(key)) { + logRecordKeys.remove(key); + Option<HoodieAvroIndexedRecord> mergedRecord = buildGenericRecordWithCustomPayload(logRecordsByKey.get(key)); + if (mergedRecord.isPresent()) { + HoodieRecord hoodieRecord = mergedRecord.get().copy(); + mergedRecordsByKey.put(key, hoodieRecord); + } + } + } + } + LOG.debug("Time taken to merge base file and log file records: {}", timer.endTimer()); + this.recordsIterator = mergedRecordsByKey.values().iterator(); + } + + @Override + public boolean hasNext() { + return recordsIterator.hasNext(); + } + + @Override + public HoodieRecord next() { + return recordsIterator.next(); + } + + public Map<String, HoodieRecord> getRecordsByKey() { + return mergedRecordsByKey; + } + + public Iterator<HoodieRecord> getRecordsIterator() { + return recordsIterator; + } + + public Map<String, HoodieRecord> getLogRecordsByKey() { + return logRecordsByKey; + } + + private static HoodieRealtimeFileSplit getRealtimeSplit(String tableBasePath, String baseFilePath, + List<HoodieLogFile> logFilePaths, + String latestInstantTime, + long start, long length, String[] hosts) { + HoodieRealtimePath realtimePath = new HoodieRealtimePath( + new Path(baseFilePath).getParent(), + baseFilePath, + tableBasePath, + logFilePaths, + latestInstantTime, + false, // TODO: Fix this to support incremental queries + Option.empty()); + return HoodieInputFormatUtils.createRealtimeFileSplit(realtimePath, start, length, hosts); + } + + private HoodieMergedLogRecordScanner getMergedLogRecordScanner() { Review Comment: Sg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
