nsivabalan commented on code in PR #8837:
URL: https://github.com/apache/hudi/pull/8837#discussion_r1254985620


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -991,10 +992,6 @@ public void update(HoodieRollbackMetadata 
rollbackMetadata, String instantTime)
       // Find the deltacommits since the last compaction
       Option<Pair<HoodieTimeline, HoodieInstant>> deltaCommitsInfo =
           
CompactionUtils.getDeltaCommitsSinceLatestCompaction(metadataMetaClient.getActiveTimeline());
-      if (!deltaCommitsInfo.isPresent() || 
deltaCommitsInfo.get().getKey().empty()) {

Review Comment:
   here irrespective of whether the commit to rollback is already present in 
MDT or not, we might have to go ahead and add the delta commit. thats why I had 
to fix this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to