danny0405 commented on code in PR #8054:
URL: https://github.com/apache/hudi/pull/8054#discussion_r1257693688
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HiveSchemaUtils.java:
##########
@@ -176,45 +177,6 @@ private static DataType
toFlinkPrimitiveType(PrimitiveTypeInfo hiveType) {
}
}
- /**
- * Create Hive field schemas from Flink table schema including the hoodie
metadata fields.
- */
- public static List<FieldSchema> toHiveFieldSchema(TableSchema schema,
boolean withOperationField) {
- List<FieldSchema> columns = new ArrayList<>();
Review Comment:
Can we modify directly on these methods instead of removing and adding new
one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
