SteNicholas opened a new pull request, #9160:
URL: https://github.com/apache/hudi/pull/9160

   ### Change Logs
   
   `HoodieHeartbeatClient` should close without stopping all heartbeats started 
via this instance of the client. Because the start of the heartbeat is executed 
in `startCommit`, therefore the stop of the heartbeat should be executed in 
`postCommit`. It doesn't need to stop all heartbeats started via this instance 
of the client when closing the `HoodieHeartbeatClient`.
   
   For example, there is a commitline generated by Flink job: 
deltacommit1.inflight(Should be recommitted), deltacommit2.inflight. Meanwhile, 
there is a clustering job with clean using lazy failed writes clean policy. The 
Flink job failed with stopping heartbeat client, then the heartbeat files are 
deleted. At this time, the clustering job could rollback the deltacommit1, 
deltacommit2. After the Flink job restarts, the deltacommit1 is rollback and 
could not recommit.
   
   ### Impact
   
   HoodieHeartbeatClient closes the client without stopping all heartbeats 
started via this instance of the client.
   
   ### Risk level (write none, low medium or high below)
   
   none.
   
   ### Documentation Update
   
   none.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [x] CI passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to