parisni commented on PR #8683: URL: https://github.com/apache/hudi/pull/8683#issuecomment-1629076136
@danny0405 The PR is ready. The way to activate comment for all engines is as below: ``` hoodie.datasource.hive_sync.sync_comment=true hoodie.datasource.hive_sync.sync_as_datasource=false ``` To recap: - `hoodie.datasource.hive_sync.sync_comment`: ads the comments in the metastore (hive, glue ...) - the current PR fixes missing comment when reading the hudi table from path (not metastore) with spark - `hoodie.datasource.hive_sync.sync_as_datasource`: allow spark to get comments from the metastore The reason spark datasource should be disabled is our current table property builder rely on parquet types which does [not know about comments](https://github.com/apache/hudi/blob/a9225bd9093e8be8f9ccdd07b0bc542994ffc4c6/hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/util/Parquet2SparkSchemaUtils.java#L36). It would be painful to modify and spark table properties are useless and leads to errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
