boneanxs commented on code in PR #9053:
URL: https://github.com/apache/hudi/pull/9053#discussion_r1259326582
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/spark/sql/hudi/execution/RangeSampleSortTest.java:
##########
@@ -0,0 +1,41 @@
+package org.apache.spark.sql.hudi.execution;
+
+import org.apache.hudi.config.HoodieClusteringConfig;
+import org.apache.hudi.testutils.HoodieClientTestBase;
+
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.util.Arrays;
+
+import scala.collection.JavaConversions;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class RangeSampleSortTest extends HoodieClientTestBase {
+
+ @Test
+ void sortDataFrameBySampleSupportAllTypes() {
+ Dataset<Row> df = this.context.getSqlContext().sql("select 1 as id,
array(2) as content");
+ for (int i = 0; i < 2; i++) {
+ final int limit = i;
+ Assertions.assertDoesNotThrow(() ->
+
RangeSampleSort$.MODULE$.sortDataFrameBySampleSupportAllTypes(df.limit(limit),
+ JavaConversions.asScalaBuffer(Arrays.asList("id", "content")),
1), "range sort shall not fail when 0 or 1 record incoming");
+ }
+ }
+
+ @Test
+ void sortDataFrameBySample() {
+ HoodieClusteringConfig.LayoutOptimizationStrategy layoutOptStrategy =
HoodieClusteringConfig.LayoutOptimizationStrategy.HILBERT;
+ Dataset<Row> df = this.context.getSqlContext().sql("select 1 as id, 2 as
content");
+ for (int i = 0; i < 2; i++) {
+ final int limit = i;
+ Assertions.assertDoesNotThrow(() ->
+ RangeSampleSort$.MODULE$.sortDataFrameBySample(df.limit(limit),
layoutOptStrategy,
+ JavaConversions.asScalaBuffer(Arrays.asList("id", "content")),
1), "range sort shall not fail when 0 or 1 record incoming");
+ }
+ }
+}
Review Comment:
Missing the end line.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/spark/sql/hudi/execution/RangeSampleSortTest.java:
##########
@@ -0,0 +1,41 @@
+package org.apache.spark.sql.hudi.execution;
+
+import org.apache.hudi.config.HoodieClusteringConfig;
+import org.apache.hudi.testutils.HoodieClientTestBase;
+
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.util.Arrays;
+
+import scala.collection.JavaConversions;
+
+import static org.junit.jupiter.api.Assertions.*;
Review Comment:
Fix this checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
