nbalajee commented on code in PR #9035:
URL: https://github.com/apache/hudi/pull/9035#discussion_r1259937078
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/TimelineServerBasedWriteMarkers.java:
##########
@@ -86,6 +89,17 @@ public TimelineServerBasedWriteMarkers(HoodieTable table,
String instantTime) {
this.timeoutSecs = timeoutSecs;
}
+ @Override
+ protected Path getMarkerPath(String partitionPath, String dataFileName,
IOType type) {
+ return new Path(partitionPath, getMarkerFileName(dataFileName, type));
+ }
Review Comment:
Timeline server based markers store relative paths of markers.
cat <basepath>/.hoodie/.temp/<ts>/markers.type
TIMELINE_SERVED_BASED
cat <basepath>/.hoodie/.temp/<ts>/MARKERS<N>
2020/06/01/file1.marker.MERGE
It was added to address test failures is my recollection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
