bvaradar commented on a change in pull request #1687:
URL: https://github.com/apache/hudi/pull/1687#discussion_r444691759
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.hudi.client.utils;
+package org.apache.hudi.common.util;
Review comment:
Got it. hudi-hadoop-mr also needs HoodieFileReader abstraction for
reading schema from file and this is reason why all these classes needs to be
in hudi-common
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java
##########
@@ -71,8 +71,9 @@ public RollbackHelper(HoodieTableMetaClient metaClient,
HoodieWriteConfig config
*/
public List<HoodieRollbackStat> performRollback(JavaSparkContext jsc,
HoodieInstant instantToRollback, List<RollbackRequest> rollbackRequests) {
+ String basefileExtension =
metaClient.getTableConfig().getBaseFileFormat().getFileExtension();
SerializablePathFilter filter = (path) -> {
- if (path.toString().contains(".parquet")) {
+ if (path.toString().contains(basefileExtension)) {
Review comment:
@prashantwason : Can you confirm if all occurrences (including tests)
are taken care of ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
