leesf commented on a change in pull request #1727:
URL: https://github.com/apache/hudi/pull/1727#discussion_r444763429
##########
File path:
hudi-client/hudi-client-spark/src/main/java/org/apache/hudi/table/action/commit/WriteHelper.java
##########
@@ -18,27 +18,32 @@
package org.apache.hudi.table.action.commit;
+import org.apache.hudi.client.WriteStatus;
+import org.apache.hudi.common.HoodieSparkEngineContext;
import org.apache.hudi.common.model.HoodieKey;
import org.apache.hudi.common.model.HoodieRecord;
import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
import org.apache.hudi.exception.HoodieUpsertException;
-import org.apache.hudi.index.HoodieIndex;
-import org.apache.hudi.table.HoodieTable;
-
+import org.apache.hudi.index.BaseHoodieIndex;
+import org.apache.hudi.table.BaseHoodieTable;
import org.apache.hudi.table.action.HoodieWriteMetadata;
+
+import org.apache.spark.api.java.JavaPairRDD;
import org.apache.spark.api.java.JavaRDD;
-import org.apache.spark.api.java.JavaSparkContext;
import java.time.Duration;
import java.time.Instant;
+
import scala.Tuple2;
public class WriteHelper<T extends HoodieRecordPayload<T>> {
- public static <T extends HoodieRecordPayload<T>> HoodieWriteMetadata
write(String instantTime,
-
JavaRDD<HoodieRecord<T>> inputRecordsRDD, JavaSparkContext jsc,
-
HoodieTable<T> table, boolean shouldCombine,
-
int shuffleParallelism, CommitActionExecutor<T> executor, boolean
performTagging) {
+ public static <T extends HoodieRecordPayload<T>>
HoodieWriteMetadata<JavaRDD<WriteStatus>> write(String instantTime,
+
JavaRDD<HoodieRecord<T>> inputRecordsRDD,
HoodieSparkEngineContext context,
+
BaseHoodieTable<T, JavaRDD<HoodieRecord<T>>,
JavaRDD<HoodieKey>, JavaRDD<WriteStatus>, JavaPairRDD<HoodieKey,
Option<Pair<String, String>>>> table, boolean shouldCombine,
+
int shuffleParallelism, SparkCommitActionExecutor<T>
executor, boolean performTagging) {
Review comment:
should also refactor the WriteHelper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
