Zouxxyy commented on code in PR #9068:
URL: https://github.com/apache/hudi/pull/9068#discussion_r1261417413
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunCompactionProcedure.scala:
##########
@@ -59,76 +61,63 @@ class RunCompactionProcedure extends BaseProcedure with
ProcedureBuilder with Sp
override def call(args: ProcedureArgs): Seq[Row] = {
super.checkArgs(PARAMETERS, args)
- val operation = getArgValueOrDefault(args,
PARAMETERS(0)).get.asInstanceOf[String].toLowerCase
+ var op = getArgValueOrDefault(args,
PARAMETERS(0)).get.asInstanceOf[String].toLowerCase
val tableName = getArgValueOrDefault(args, PARAMETERS(1))
val tablePath = getArgValueOrDefault(args, PARAMETERS(2))
val instantTimestamp = getArgValueOrDefault(args, PARAMETERS(3))
var confs: Map[String, String] = Map.empty
if (getArgValueOrDefault(args, PARAMETERS(4)).isDefined) {
confs = confs ++
HoodieCLIUtils.extractOptions(getArgValueOrDefault(args,
PARAMETERS(4)).get.asInstanceOf[String])
}
+ var specificInstants = getArgValueOrDefault(args, PARAMETERS(5))
+
+ // For old version compatibility
+ if (op.equals("run")) {
+ op = "scheduleandexecute"
+ }
+ if (instantTimestamp.isDefined && specificInstants.isEmpty) {
Review Comment:
> Users will no longer to perform a schedule with a pre-defined instant.
(This is exceptionally useful if they are running a schedule operation in a
cluster that is running in a different timezone, setting a timestamp/instant
manually allows us to override timezones aids testing.)
yes, this feature has been removed. I didn't think it was necessary to
manually specify the schedule plan's timestamp before, and it can be dangerous
because it may break the timeline. As for the time zone issue, we maybe can
modify the timezone directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
