danny0405 commented on code in PR #9175:
URL: https://github.com/apache/hudi/pull/9175#discussion_r1261916555
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -408,8 +408,13 @@ private void initInstant(String instant) {
HoodieTimeline completedTimeline =
this.metaClient.getActiveTimeline().filterCompletedInstants();
executor.execute(() -> {
if (instant.equals(WriteMetadataEvent.BOOTSTRAP_INSTANT) ||
completedTimeline.containsInstant(instant)) {
- // the last instant committed successfully
+ // We don't need to recommit for completed or failed writes
Review Comment:
The incidence should be very low, let's keep the PR suspending to enlighten
more ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
